-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New Vite plugin docs for local development #20586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyperlint Review is complete!
Hyperlint Vale Style Guide Review
Reviewed 3 files and found 3 issues.
See the inline comments and suggestions below.
Hyperlint Link Check Review
Reviewed 3 files and found 0 issues.
We are upgrading our reviewer model! Going forward, our model will learn your particular style - which comments you all accept and reject, so that it can further personalize its suggestions.
What is Hyperlint?
Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. It can review, edit, and suggest fixes for your documentation.
Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.
Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. |
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
…dflare-docs into korinne-vite-plugin-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like would need to combine with https://github.com/cloudflare/cloudflare-docs/blob/production/src/content/docs/workers/local-development.mdx ?
…to korinne-vite-plugin-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've made a few suggestions.
src/content/docs/workers/local-development/environment-variables.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/local-development/environment-variables.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/local-development/environment-variables.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in my earlier comment, I think it would be good to move this content to the overview.
src/content/docs/workers/local-development/environment-variables.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/local-development/environment-variables.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/local-development/environment-variables.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/local-development/wrangler-vs-vite.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/local-development/wrangler-vs-vite.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: James Opstad <[email protected]>
Co-authored-by: James Opstad <[email protected]>
Co-authored-by: Kody Jackson <[email protected]>
Co-authored-by: Kody Jackson <[email protected]>
Co-authored-by: Kody Jackson <[email protected]>
Co-authored-by: Kody Jackson <[email protected]>
Co-authored-by: Brendan Irvine-Broque <[email protected]>
Co-authored-by: James Opstad <[email protected]>
* Initial Vite plugin docs * Update src/content/docs/workers/vite-plugin/api.mdx Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> * Update src/content/docs/workers/vite-plugin/api.mdx Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> * adds a directory structure for local development docs, and adds a Vite plugin section * Update src/content/docs/workers/local-development/vite.mdx Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> * Update src/content/docs/workers/local-development/wrangler.mdx Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> * fix some broken links * consolidates current local dev docs under new directory, and includes ⛅️ wrangler 3.95.0 (update available 3.114.1) ---------------------------------------------- in Overview page * Uses new PackageManager component in local-development/wrangler.mdx * adds bindings_per_env.mdx under src/content/partials/workers * Adds guidance for when to use Wrangler vs Vite, adds Vite to the binding comparison * updates Wrangler local development guide, and partial for local vs remote dev * updates overview page to make more concise * fixes broken links * Update src/content/docs/workers/local-development/vite.mdx Co-authored-by: James Opstad <[email protected]> * Update src/content/docs/workers/local-development/vite.mdx Co-authored-by: James Opstad <[email protected]> * Update src/content/docs/workers/local-development/vite.mdx Co-authored-by: James Opstad <[email protected]> * Update src/content/docs/workers/local-development/index.mdx Co-authored-by: James Opstad <[email protected]> * moves local development section nearer to testing section * cleans up text in choosing between wrangler and vite * updates overview page for local development * update overview page, add working with data page * updates local development docs * Update src/content/docs/workers/local-development/local-data.mdx Co-authored-by: James Opstad <[email protected]> * Update src/content/docs/workers/local-development/local-data.mdx Co-authored-by: James Opstad <[email protected]> * Update src/content/docs/workers/local-development/wrangler-vs-vite.mdx Co-authored-by: Kody Jackson <[email protected]> * Update src/content/docs/workers/local-development/remote-data.mdx Co-authored-by: Kody Jackson <[email protected]> * Update src/content/docs/workers/local-development/local-data.mdx Co-authored-by: Kody Jackson <[email protected]> * Update src/content/docs/workers/local-development/local-data.mdx Co-authored-by: Kody Jackson <[email protected]> * Update src/content/docs/workers/local-development/local-data.mdx Co-authored-by: Brendan Irvine-Broque <[email protected]> * Update src/content/docs/workers/local-development/index.mdx Co-authored-by: James Opstad <[email protected]> * adds updates to remove separate vite vs wrangler docs, small changes * updates local-data.mdx * Update src/content/docs/workers/local-development/remote-data.mdx --------- Co-authored-by: James Opstad <[email protected]> Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> Co-authored-by: Kody Jackson <[email protected]> Co-authored-by: Brendan Irvine-Broque <[email protected]>
Summary
wrangler dev
) and the new Cloudflare Vite pluginDocumentation checklist