-
Notifications
You must be signed in to change notification settings - Fork 6.5k
[Workers] Add getting started guide for API and IaC #21008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: production
Are you sure you want to change the base?
Conversation
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryAdded a getting started guide for the Workers API and Infrastructure as Code (IaC) to assist users in uploading scripts with content and metadata.
Modified Files
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
50b9991
to
741a430
Compare
741a430
to
958e08f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's find right home for this content and do bit more here
c7df2be
to
60ec915
Compare
@irvinebroque moved to Platform > Managing Workers which feels appropriate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
5ece160
to
f629f24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think there is a lot to each of these sections, ex each of these is worthy of a section
Infrastructure-as-Code (Iac)
- Overview
- Terraform
- API SDKs
- Cloudflare REST API
Also things to consider about discoverableility from here:
https://developers.cloudflare.com/terraform/additional-configurations
Also seems like this example really shows how much about multipart upload metadata is bleeding into the SDK API:
lot of stuff in order to just take a file and deploy it to us.
}} | ||
/> | ||
|
||
### Terraform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What guidance do we give on when to use / not to use?
f629f24
to
ddb8f33
Compare
ddb8f33
to
0ed35ff
Compare
0ed35ff
to
c45a99b
Compare
c45a99b
to
372ca8c
Compare
Don't merge until...
|
Summary
There are no official documented examples of how to properly upload a workers script with content and metadata. This is a non-starter for API users. Ideally these examples could live in the API docs themselves, but we can't make custom examples there yet. This doc serves as a practical guide in the meantime that will unblock users.
Documentation checklist