Skip to content

Use one.one.one.one in example #21301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

miyurusankalpa
Copy link
Contributor

Summary

Current given IPv4 example, does not work in IPv6 only servers.

Screenshots (optional)

Documentation checklist

current given IPv4 example, does not work in IPv6 only servers.
@miyurusankalpa miyurusankalpa requested review from RebeccaTamachiro and a team as code owners April 1, 2025 18:46
Copy link
Contributor

hyperlint-ai bot commented Apr 1, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated the example in the DNS over HTTPS documentation to use the correct domain for Cloudflare's DNS service.

  • Replaced the IPv4 address example with the domain name 'one.one.one.one' for clarity.
  • Ensured compatibility with IPv6 only servers by using the domain name instead of the IP address.

Modified Files

  • src/content/docs/1.1.1.1/encryption/dns-over-https/make-api-requests/index.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions github-actions bot added size/xs product:1.1.1.1 Related to 1.1.1.1 product labels Apr 1, 2025
@RebeccaTamachiro RebeccaTamachiro enabled auto-merge (squash) April 10, 2025 08:28
@RebeccaTamachiro RebeccaTamachiro merged commit 4a930bc into cloudflare:production Apr 10, 2025
7 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Apr 10, 2025
Copy link

holopin-bot bot commented Apr 10, 2025

Congratulations @miyurusankalpa, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm9b53z1g65020cl4yqpov8ci

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes a docs contribution, big or small product:1.1.1.1 Related to 1.1.1.1 product size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants