Skip to content

[MNN] New rule types #21448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Apr 7, 2025
Merged

[MNN] New rule types #21448

merged 35 commits into from
Apr 7, 2025

Conversation

marciocloudflare
Copy link
Contributor

@marciocloudflare marciocloudflare commented Apr 7, 2025

Summary

Closes PCX-14525

Documentation checklist

Copy link
Contributor

hyperlint-ai bot commented Apr 7, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Introduced new rule types for Magic Network Monitoring, enhancing DDoS protection capabilities.

  • Added a new dynamic threshold rule for automatic DDoS threshold adjustments based on traffic patterns.
  • Introduced a new sFlow DDoS attack rule for customers sending sFlow data to Cloudflare.
  • Updated existing documentation to reflect changes in rule types and configurations.

Modified Files

  • src/content/docs/magic-network-monitoring/index.mdx
  • src/content/docs/magic-network-monitoring/rules/index.mdx

Added Files

  • src/content/docs/magic-network-monitoring/rules/dynamic-threshold.mdx
  • src/content/docs/magic-network-monitoring/rules/rule-notifications.mdx
  • src/content/docs/magic-network-monitoring/rules/s-flow-ddos-attack.mdx

Renamed Files

  • src/content/docs/magic-network-monitoring/rules/static-threshold.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:

  • /magic-network-monitoring/notifications/
  • /magic-network-monitoring/rules/sflow-ddos-alerts/
  • /magic-network-monitoring/rules/recommended-rule-configuration/

Copy link
Contributor

github-actions bot commented Apr 7, 2025

Preview URL: https://23523eae.preview.developers.cloudflare.com
Preview Branch URL: https://marcio-pcx14525-nmn-zscore.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/magic-network-monitoring/rules/ https://marcio-pcx14525-nmn-zscore.preview.developers.cloudflare.com/magic-network-monitoring/rules/
https://developers.cloudflare.com/magic-network-monitoring/rules/rule-notifications/ https://marcio-pcx14525-nmn-zscore.preview.developers.cloudflare.com/magic-network-monitoring/rules/rule-notifications/
https://developers.cloudflare.com/magic-network-monitoring/rules/static-threshold/ https://marcio-pcx14525-nmn-zscore.preview.developers.cloudflare.com/magic-network-monitoring/rules/static-threshold/
https://developers.cloudflare.com/magic-network-monitoring/rules/dynamic-threshold/ https://marcio-pcx14525-nmn-zscore.preview.developers.cloudflare.com/magic-network-monitoring/rules/dynamic-threshold/
https://developers.cloudflare.com/magic-network-monitoring/rules/s-flow-ddos-attack/ https://marcio-pcx14525-nmn-zscore.preview.developers.cloudflare.com/magic-network-monitoring/rules/s-flow-ddos-attack/
https://developers.cloudflare.com/magic-network-monitoring/rules/sflow-ddos-alerts/ https://marcio-pcx14525-nmn-zscore.preview.developers.cloudflare.com/magic-network-monitoring/rules/sflow-ddos-alerts/
https://developers.cloudflare.com/magic-network-monitoring/notifications/ https://marcio-pcx14525-nmn-zscore.preview.developers.cloudflare.com/magic-network-monitoring/notifications/
https://developers.cloudflare.com/magic-network-monitoring/ https://marcio-pcx14525-nmn-zscore.preview.developers.cloudflare.com/magic-network-monitoring/

@marciocloudflare marciocloudflare enabled auto-merge (squash) April 7, 2025 11:40
@marciocloudflare marciocloudflare merged commit 2bf519e into production Apr 7, 2025
11 checks passed
@marciocloudflare marciocloudflare deleted the marcio/pcx14525-nmn-zscore branch April 7, 2025 11:58
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
* added new content

* refined text

* refined text

* deleted old pages

* added static threshold

* refined text

* refined text

* refined text

* added dynamic threshold

* refined text

* refined url

* refined title

* refined url

* refined text

* refined text

* added sflow rule

* corrected url

* refined text

* refined text

* refined text

* added ul

* added rule notifications

* refined text

* refined text

* refined text

* refined links

* refined text

* refined url

* refined text

* deleted old notification page

* added redirects

* corrected link

* refined text

* Apply suggestions from code review

Co-authored-by: Kate Tungusova <[email protected]>

* refined text

---------

Co-authored-by: Kate Tungusova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants