-
Notifications
You must be signed in to change notification settings - Fork 6.5k
update C3 instructions for Pages projects #22005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated C3 instructions to require the
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
Preview URL: https://532183e9.preview.developers.cloudflare.com Files with changes (up to 15)
|
0ea6737
to
5cb32a2
Compare
It is now required to pass `--platform=pages` to create a Pages project.
5cb32a2
to
532183e
Compare
@petebacondarwin thanks for putting this up! can you add the |
Is that actually the right thing to do here? The only options for |
hmm, good question. the CLI arguments being listed in this section conflates pages-specific concerns with more general c3 documentation, especially given the wording: we might want to consider reorganizing some of the c3 documentation, but that's not within the scope of this PR, so we can table my comment for now and revisit later if makes sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this just be inlined? Why is it a partial?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. I guess the original plan was that it would be reused for Pages and Workers?
Summary
It is now required to pass
--platform=pages
to create a Pages project.Screenshots (optional)
Documentation checklist