[BRAPI]chromium version details #22013
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryAdded details about the Chromium version used in the Workers Binding API documentation.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
daisyfaithauma
changed the title
daisyfaithauma
requested review from
mchenco,
celso,
danielgek,
kathayl and
a team
as code owners
|
updated content added output more explanation on how to use
|
actually, just made the edits i commented above myself Waiting for preview, so not sure if the formatting is correct. But could you also add the formatting so that playwright and puppeteer instructions are tab example so someone can just switch between them versus seeing all of it? |
wording updates
| <Tabs syncKey="workersExamples"> <TabItem label="Puppeteer"> | ||
|
|
||
| ```javascript | ||
| const puppeteer = require("puppeteer"); |
There was a problem hiding this comment.
Shouldn't this be
import puppeteer from "@cloudflare/puppeteer";
| const puppeteer = require("puppeteer"); | ||
|
|
||
| (async () => { | ||
| const browser = await puppeteer.launch(); |
There was a problem hiding this comment.
and this: const browser = await puppeteer.launch(env.MYBROWSER);
| ```javascript | ||
| const puppeteer = require("puppeteer"); | ||
|
|
||
| (async () => { |
There was a problem hiding this comment.
And should this be inside a worker fetch?
Like the code here: https://developers.cloudflare.com/browser-rendering/workers-binding-api/screenshots/#5-code
|
|
||
| The Workers Browser Rendering API allows developers to programmatically control and interact with a headless browser instance and create automation flows for their applications and products. Once you configure the service, Workers Browser Rendering gives you access to a WebSocket endpoint that speaks the [DevTools Protocol](https://chromedevtools.github.io/devtools-protocol/). DevTools is what allows Cloudflare to instrument a Chromium instance running in the Cloudflare global network. | ||
|
|
||
| ### Checking chromium version |
There was a problem hiding this comment.
Question about placement, can you talk me through your reasoning for placing this section on this page + area of the page?
|
|
||
| ## Chromium version | ||
|
|
||
| Cloudflare Browser Rendering currently uses **Chromium version 124.0.6367.257**. |
There was a problem hiding this comment.
This info really shouldn't be on the current page (per my previous comment). Should either be a new page or a section on a new page.
Please apply to #22043 as well.
| </TabItem> <TabItem label="Playwright"> | ||
|
|
||
| ```javascript | ||
| const { chromium } = require("playwright"); |
There was a problem hiding this comment.
I think this should be @cloudflare/playwright
please see the examples here for reference: https://developers.cloudflare.com/browser-rendering/platform/playwright/
| ```javascript | ||
| const { chromium } = require("playwright"); | ||
|
|
||
| (async () => { |
There was a problem hiding this comment.
Still not sure if I understand, but why do we not have this example in a worker?
| const { chromium } = require("playwright"); | ||
|
|
||
| (async () => { | ||
| const browser = await chromium.launch(); |
There was a problem hiding this comment.
we should pass theenv.MYBROWSER here also
MYBROWSER is the binding you use in your wrangler.toml
Summary
Screenshots (optional)
Documentation checklist