-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Adding warning about re-accessing request.formData() in all relevant places #22018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
places where the code uses request.formData().
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryEnhanced documentation by adding a warning about the single access limitation of request.formData() across multiple relevant pages.
Modified Files
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
Co-authored-by: daisyfaithauma <[email protected]>
Correction: #22025 |
Summary
The body of a Request can only be accessed once. This is explained in the warning note here:
Previously, this warning note was only present in a single page in R2. Now, this PR adds the warning note in all places where we show a code snippet which uses
request.formData()
, so that a user is aware of it (in case they use the code snippet as a springboard to create new code).Screenshots (optional)
Documentation checklist