-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Extend D1 docs with clarifications for one-way type conversions #22093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend D1 docs with clarifications for one-way type conversions #22093
Conversation
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryExtended D1 documentation to clarify one-way type conversions and their implications for users.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
|
||
<sup>1</sup> D1 supports 64-bit signed `INTEGER` values internally, however | ||
<sup>1</sup> D1 types correspond to the underlying [SQLite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Oxyjun How can we make the footnotes to show on hover? I assume there is some component we can migrate too?
Feel free to checkout and edit this PR directly, BTW.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll tackle the footnotes in a separate PR across all the pages. For reference though, this is how the hover footnote works:
Text [^1]
[^1]: Footnote
https://developers.cloudflare.com/style-guide/components/footnotes/
Thanks! |
Clarify the type conversion happening in D1 to avoid confusion by users. Example: cloudflare/workers-sdk#8642
eb5b0a9
to
e299b6e
Compare
* Extend D1 docs with clarifications for one-way type conversions Clarify the type conversion happening in D1 to avoid confusion by users. Example: cloudflare/workers-sdk#8642 * PCX Review --------- Co-authored-by: Jun Lee <[email protected]>
Summary
fixes cloudflare/workers-sdk#8642
Clarify the type conversion happening in D1 to avoid confusion by users. Example: cloudflare/workers-sdk#8642
All the conversions are done in the D1 Worker binding inside the
bind()
method: https://github.com/cloudflare/workerd/blob/cf9071a1bda90dd3148bb49c38d06f39beb6bd52/src/cloudflare/internal/d1-api.ts#L380Documentation checklist
Test
I created the following worker to confirm the conversions.
Running that returns: