-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Pages banner #22134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: production
Are you sure you want to change the base?
Pages banner #22134
Conversation
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryImplemented a dismissible banner at the top of the pages and added visual enhancements to the sidebar.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
Howdy @GregBrimble, curious on the benefit to this vs manually adding a banner to all the pages in this section? As long as the messaging would be the same, the risk of anything getting out of date (or even needing to update) wouldn't be that high. |
Yes, that's my plan! This is just a prototype of the functionality — only added to the product homepage. I'll be adding it manually to all child pages. |
4949078
to
4239f2f
Compare
4239f2f
to
c27097f
Compare
e5f127f
to
516ee55
Compare
516ee55
to
2713ded
Compare
2713ded
to
6e08f77
Compare
This is really really nice 👏 |
95d1e20
to
8fa54c0
Compare
This looks amazing! Thanks for checking on the banner design! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two weird things.
-
Sparkle alignment in Safari, seems out of place? Chrome and Firefox look good.
-
Banner text alignment for normal banners, see this page at larger screen sizes.
@@ -1,3 +1,24 @@ | |||
diff --git a/node_modules/@astrojs/starlight/components/SidebarSublist.astro b/node_modules/@astrojs/starlight/components/SidebarSublist.astro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the patch solely for the sparkle icon?
(forgive me, can't exactly tell from the code itself)
If so, would it be more sustainable to refactor to add in the sidebar.ts file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, yeah. It's about rendering the icon. util/sidebar.ts
is about collecting the data that we eventually want to render. So, appropriately, I did have to make some modifications there about which icons are relevant for which entries. But this change is still needed to actually print it to the page.
Summary
Sparkles on the sidebar, and a dismissible banner at the top.
Screenshots (optional)
Documentation checklist