Persist activeAccountId in UserDetails DO so we can persist activeAccountId selection across sessions (#81)

* Add RequiredScopes, and remove unnecessary observability scope from container and bindings servers

* Persist activeAccountId in UserDetails DO so we can persist activeAccountId selection across sessions

Author: Maximo-Guk

apps/docs-autorag/src/context.ts

@@ -3,8 +3,8 @@ import type { CloudflareDocumentationMCP } from './index'
 export interface Env {
 	ENVIRONMENT: 'development' | 'staging' | 'production'
 	AUTORAG_NAME: 'cloudflare-docs-autorag'
-	MCP_SERVER_NAME: 'PLACEHOLDER'
-	MCP_SERVER_VERSION: 'PLACEHOLDER'
+	MCP_SERVER_NAME: string
+	MCP_SERVER_VERSION: string
 	MCP_OBJECT: DurableObjectNamespace<CloudflareDocumentationMCP>
 	MCP_METRICS: AnalyticsEngineDataset
 	AI: Ai

apps/sandbox-container/server/context.ts

@@ -2,11 +2,11 @@ import type { ContainerManager, ContainerMcpAgent } from './index'
 
 export interface Env {
 	OAUTH_KV: KVNamespace
-	CLOUDFLARE_CLIENT_ID: '<PLACEHOLDER>'
-	CLOUDFLARE_CLIENT_SECRET: '<PLACEHOLDER>'
+	CLOUDFLARE_CLIENT_ID: string
+	CLOUDFLARE_CLIENT_SECRET: string
 	ENVIRONMENT: 'dev'
-	MCP_SERVER_NAME: '<PLACEHOLDER>'
-	MCP_SERVER_VERSION: '<PLACEHOLDER>'
+	MCP_SERVER_NAME: string
+	MCP_SERVER_VERSION: string
 	OPENAI_API_KEY: string
 	CONTAINER_MCP_AGENT: DurableObjectNamespace<ContainerMcpAgent>
 	CONTAINER_MANAGER: DurableObjectNamespace<ContainerManager>

apps/workers-bindings/src/context.ts

@@ -1,12 +1,14 @@
+import type { UserDetails } from '@repo/mcp-common/src/durable-objects/user_details'
 import type { WorkersBindingsMCP } from './index'
 
 export interface Env {
 	OAUTH_KV: KVNamespace
 	ENVIRONMENT: 'development' | 'staging' | 'production'
-	MCP_SERVER_NAME: '<PLACEHOLDER>'
-	MCP_SERVER_VERSION: '<PLACEHOLDER>'
-	CLOUDFLARE_CLIENT_ID: '<PLACEHOLDER>'
-	CLOUDFLARE_CLIENT_SECRET: '<PLACEHOLDER>'
+	MCP_SERVER_NAME: string
+	MCP_SERVER_VERSION: string
+	CLOUDFLARE_CLIENT_ID: string
+	CLOUDFLARE_CLIENT_SECRET: string
 	MCP_OBJECT: DurableObjectNamespace<WorkersBindingsMCP>
+	USER_DETAILS: DurableObjectNamespace<UserDetails>
 	MCP_METRICS: AnalyticsEngineDataset
 }

apps/workers-bindings/src/index.ts

@@ -5,6 +5,7 @@ import {
 	createAuthHandlers,
 	handleTokenExchangeCallback,
 } from '@repo/mcp-common/src/cloudflare-oauth-handler'
+import { getUserDetails, UserDetails } from '@repo/mcp-common/src/durable-objects/user_details'
 import { getEnv } from '@repo/mcp-common/src/env'
 import { RequiredScopes } from '@repo/mcp-common/src/scopes'
 import { CloudflareMCPServer } from '@repo/mcp-common/src/server'
@@ -18,6 +19,8 @@ import { MetricsTracker } from '@repo/mcp-observability'
 import type { AccountSchema, UserSchema } from '@repo/mcp-common/src/cloudflare-oauth-handler'
 import type { Env } from './context'
 
+export { UserDetails }
+
 const env = getEnv<Env>()
 
 const metrics = new MetricsTracker(env.MCP_METRICS, {
@@ -73,24 +76,25 @@ export class WorkersBindingsMCP extends McpAgent<Env, WorkersBindingsMCPState, P
 		registerR2BucketTools(this)
 		registerD1Tools(this)
 	}
-	getActiveAccountId() {
-		// TODO: Figure out why this fail sometimes, and why we need to wrap this in a try catch
+
+	async getActiveAccountId() {
 		try {
-			return this.state.activeAccountId ?? null
+			// Get UserDetails Durable Object based off the userId and retrieve the activeAccountId from it
+			// we do this so we can persist activeAccountId across sessions
+			const userDetails = getUserDetails(env, this.props.user.id)
+			return await userDetails.getActiveAccountId()
 		} catch (e) {
+			this.server.recordError(e)
 			return null
 		}
 	}
 
-	setActiveAccountId(accountId: string) {
-		// TODO: Figure out why this fail sometimes, and why we need to wrap this in a try catch
+	async setActiveAccountId(accountId: string) {
 		try {
-			this.setState({
-				...this.state,
-				activeAccountId: accountId,
-			})
+			const userDetails = getUserDetails(env, this.props.user.id)
+			await userDetails.setActiveAccountId(accountId)
 		} catch (e) {
-			return null
+			this.server.recordError(e)
 		}
 	}
 }

apps/workers-bindings/wrangler.jsonc

@@ -19,6 +19,10 @@
 			{
 				"class_name": "WorkersBindingsMCP",
 				"name": "MCP_OBJECT"
+			},
+			{
+				"class_name": "UserDetails",
+				"name": "USER_DETAILS"
 			}
 		]
 	},
@@ -59,6 +63,11 @@
 					{
 						"class_name": "WorkersBindingsMCP",
 						"name": "MCP_OBJECT"
+					},
+					{
+						"class_name": "UserDetails",
+						"name": "USER_DETAILS",
+						"script_name": "mcp-cloudflare-workers-observability-staging"
 					}
 				]
 			},
@@ -69,7 +78,9 @@
 				}
 			],
 			"vars": {
-				"ENVIRONMENT": "staging"
+				"ENVIRONMENT": "staging",
+				"MCP_SERVER_NAME": "workers-bindings-staging",
+				"MCP_SERVER_VERSION": "1.0.0"
 			},
 			"analytics_engine_datasets": [
 				{
@@ -87,6 +98,11 @@
 					{
 						"class_name": "WorkersBindingsMCP",
 						"name": "MCP_OBJECT"
+					},
+					{
+						"class_name": "UserDetails",
+						"name": "USER_DETAILS",
+						"script_name": "mcp-cloudflare-workers-observability-production"
 					}
 				]
 			},
@@ -97,7 +113,9 @@
 				}
 			],
 			"vars": {
-				"ENVIRONMENT": "production"
+				"ENVIRONMENT": "production",
+				"MCP_SERVER_NAME": "workers-bindings",
+				"MCP_SERVER_VERSION": "1.0.0"
 			},
 			"analytics_engine_datasets": [
 				{

apps/workers-observability/src/context.ts

@@ -1,16 +1,18 @@
+import type { UserDetails } from '@repo/mcp-common/src/durable-objects/user_details'
 import type { ObservabilityMCP } from './index'
 
 export interface Env {
 	OAUTH_KV: KVNamespace
 	ENVIRONMENT: 'development' | 'staging' | 'production'
-	MCP_SERVER_NAME: 'PLACEHOLDER'
-	MCP_SERVER_VERSION: 'PLACEHOLDER'
-	CLOUDFLARE_CLIENT_ID: 'PLACEHOLDER'
-	CLOUDFLARE_CLIENT_SECRET: 'PLACEHOLDER'
+	MCP_SERVER_NAME: string
+	MCP_SERVER_VERSION: string
+	CLOUDFLARE_CLIENT_ID: string
+	CLOUDFLARE_CLIENT_SECRET: string
 	MCP_OBJECT: DurableObjectNamespace<ObservabilityMCP>
+	USER_DETAILS: DurableObjectNamespace<UserDetails>
 	MCP_METRICS: AnalyticsEngineDataset
-	SENTRY_ACCESS_CLIENT_ID: 'PLACEHOLDER'
-	SENTRY_ACCESS_CLIENT_SECRET: 'PLACEHOLDER'
-	GIT_HASH: 'OVERRIDEN_DURING_DEPLOYMENT'
-	SENTRY_DSN: 'PLACEHOLDER'
+	SENTRY_ACCESS_CLIENT_ID: string
+	SENTRY_ACCESS_CLIENT_SECRET: string
+	GIT_HASH: string
+	SENTRY_DSN: string
 }

apps/workers-observability/src/index.ts

@@ -5,6 +5,7 @@ import {
 	createAuthHandlers,
 	handleTokenExchangeCallback,
 } from '@repo/mcp-common/src/cloudflare-oauth-handler'
+import { getUserDetails, UserDetails } from '@repo/mcp-common/src/durable-objects/user_details'
 import { getEnv } from '@repo/mcp-common/src/env'
 import { RequiredScopes } from '@repo/mcp-common/src/scopes'
 import { initSentryWithUser } from '@repo/mcp-common/src/sentry'
@@ -18,6 +19,8 @@ import { registerLogsTools } from './tools/logs'
 import type { AccountSchema, UserSchema } from '@repo/mcp-common/src/cloudflare-oauth-handler'
 import type { Env } from './context'
 
+export { UserDetails }
+
 const env = getEnv<Env>()
 
 const metrics = new MetricsTracker(env.MCP_METRICS, {
@@ -72,26 +75,24 @@ export class ObservabilityMCP extends McpAgent<Env, State, Props> {
 		registerLogsTools(this)
 	}
 
-	getActiveAccountId() {
-		// TODO: Figure out why this fail sometimes, and why we need to wrap this in a try catch
+	async getActiveAccountId() {
 		try {
-			return this.state.activeAccountId ?? null
+			// Get UserDetails Durable Object based off the userId and retrieve the activeAccountId from it
+			// we do this so we can persist activeAccountId across sessions
+			const userDetails = getUserDetails(env, this.props.user.id)
+			return await userDetails.getActiveAccountId()
 		} catch (e) {
 			this.server.recordError(e)
 			return null
 		}
 	}
 
-	setActiveAccountId(accountId: string) {
-		// TODO: Figure out why this fail sometimes, and why we need to wrap this in a try catch
+	async setActiveAccountId(accountId: string) {
 		try {
-			this.setState({
-				...this.state,
-				activeAccountId: accountId,
-			})
+			const userDetails = getUserDetails(env, this.props.user.id)
+			await userDetails.setActiveAccountId(accountId)
 		} catch (e) {
 			this.server.recordError(e)
-			return null
 		}
 	}
 }

apps/workers-observability/src/tools/logs.ts

@@ -123,7 +123,7 @@ export function registerLogsTools(agent: ObservabilityMCP) {
 			rayId: rayIdParam,
 		},
 		async (params) => {
-			const accountId = agent.getActiveAccountId()
+			const accountId = await agent.getActiveAccountId()
 			if (!accountId) {
 				return {
 					content: [
@@ -188,7 +188,7 @@ export function registerLogsTools(agent: ObservabilityMCP) {
 			minutesAgoParam,
 		},
 		async (params) => {
-			const accountId = agent.getActiveAccountId()
+			const accountId = await agent.getActiveAccountId()
 			if (!accountId) {
 				return {
 					content: [
@@ -248,7 +248,7 @@ export function registerLogsTools(agent: ObservabilityMCP) {
 		'Get available telemetry keys for a Cloudflare Worker',
 		{ scriptName: workerNameParam, minutesAgoParam },
 		async (params) => {
-			const accountId = agent.getActiveAccountId()
+			const accountId = await agent.getActiveAccountId()
 			if (!accountId) {
 				return {
 					content: [

apps/workers-observability/wrangler.jsonc

@@ -10,7 +10,7 @@
 	"name": "mcp-cloudflare-workers-observability-dev",
 	"migrations": [
 		{
-			"new_sqlite_classes": ["ObservabilityMCP"],
+			"new_sqlite_classes": ["UserDetails", "ObservabilityMCP"],
 			"tag": "v1"
 		}
 	],
@@ -22,6 +22,10 @@
 			{
 				"class_name": "ObservabilityMCP",
 				"name": "MCP_OBJECT"
+			},
+			{
+				"class_name": "UserDetails",
+				"name": "USER_DETAILS"
 			}
 		]
 	},
@@ -59,6 +63,10 @@
 					{
 						"class_name": "ObservabilityMCP",
 						"name": "MCP_OBJECT"
+					},
+					{
+						"class_name": "UserDetails",
+						"name": "USER_DETAILS"
 					}
 				]
 			},
@@ -72,7 +80,7 @@
 				"ENVIRONMENT": "staging",
 				"GIT_HASH": "OVERRIDEN_DURING_DEPLOYMENT",
 				"SENTRY_DSN": "https://[email protected]/1764",
-				"MCP_SERVER_NAME": "workers-staging-observability",
+				"MCP_SERVER_NAME": "workers-observability-staging",
 				"MCP_SERVER_VERSION": "1.0.0"
 			},
 			"analytics_engine_datasets": [
@@ -91,6 +99,10 @@
 					{
 						"class_name": "ObservabilityMCP",
 						"name": "MCP_OBJECT"
+					},
+					{
+						"class_name": "UserDetails",
+						"name": "USER_DETAILS"
 					}
 				]
 			},