Skip to content

Persist activeAccountId in UserDetails DO so we can persist activeAccountId selection across sessions #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Maximo-Guk
Copy link
Member

@Maximo-Guk Maximo-Guk commented Apr 26, 2025

Introduces a new "UserDetails" Durable Object for persisting UserDetails in DO storage across sessions based off the userId

@Maximo-Guk Maximo-Guk requested a review from cmsparks April 26, 2025 23:29
@Maximo-Guk Maximo-Guk force-pushed the maximo/persist-state-in-user-do branch 2 times, most recently from 535453d to c5b3a69 Compare April 27, 2025 00:06
@Maximo-Guk Maximo-Guk force-pushed the maximo/persist-state-in-user-do branch from c5b3a69 to a9497e5 Compare April 27, 2025 00:11
{
"class_name": "UserDetails",
"name": "USER_DETAILS",
"script_name": "mcp-cloudflare-workers-observability-production"
Copy link
Member Author

@Maximo-Guk Maximo-Guk Apr 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking we'll likely want to create a separate worker which hosts the USER_DETAILS durable objects

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave this to a separate PR, once we start storing data that needs to be retained ( we can always prompt the user for their accountId again )

@Maximo-Guk Maximo-Guk requested a review from deloreyj April 28, 2025 15:02
@Maximo-Guk Maximo-Guk force-pushed the maximo/add-required-scopes branch from a480d7e to 57f7cd7 Compare April 28, 2025 16:27
@Maximo-Guk Maximo-Guk merged commit c009a13 into maximo/add-required-scopes Apr 28, 2025
3 checks passed
@Maximo-Guk Maximo-Guk deleted the maximo/persist-state-in-user-do branch April 28, 2025 16:35
@Maximo-Guk Maximo-Guk restored the maximo/persist-state-in-user-do branch April 28, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants