-
Notifications
You must be signed in to change notification settings - Fork 140
Add AutoRAG mcp server #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
47a7e65
to
48fc7f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the tool description + response related issues, otherwise lgtm
apps/autorag/src/tools/autorag.ts
Outdated
export function registerAutoRAGTools(agent: AutoRAGMCP) { | ||
agent.server.tool( | ||
'list_rags', | ||
'List Rags (vector stores)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd probably want a slightly larger description for all of these for the LLMs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also add server instructions (but that's not 100% necessary):
options: { instructions: BASE_INSTRUCTIONS }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added clearer descriptions to all fields
apps/autorag/src/tools/autorag.ts
Outdated
|
||
agent.server.tool( | ||
'search', | ||
'Search Rag (vector store)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add an option to limit search result lengths (alongside a more limited default)? I used autorag with the docs MCP server, which ran into a lot of context length issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added limit to 5 results in chunk search and 10 result when asking for just an ai response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also updated all tools response to be simpler for the llm to understand, removing unused fields and converting the chunk search into a single text instead of being a json with a bunch of fields
48fc7f5
to
c10c0f3
Compare
c10c0f3
to
0dbcd19
Compare
If you could push these branches up to Cloudflare org from the fork, that would be super great ( so we can get CI to run ) |
done, ci is now green |
can this be merged? |
Go for it @G4brym ! |
Merged on your behalf |
No description provided.