Remove unused fields from list accounts mcp tool #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celso
approved these changes
Apr 30, 2025
Maximo-Guk
reviewed
Apr 30, 2025
| @@ -20,6 +20,13 @@ export function registerAccountTools(agent: CloudflareMcpAgent) { | |||
| if (!b.created_on) return -1 | |||
| return new Date(b.created_on).getTime() - new Date(a.created_on).getTime() | |||
| }) | |||
| // Remove fields not needed by the LLM | |||
| .map((account) => { | |||
There was a problem hiding this comment.
I've personally found it kinda useful for account list tool to display created_on dates in some chats. Maybe it makes sense to do this limiting, only once we've returned > 10 accounts or some other reasonable number?
Also perhaps we can inform the LLM that the output here is sorted, so it also has that context
There was a problem hiding this comment.
maybe we could introduce pagination on this tool, and keep the created_on property
There was a problem hiding this comment.
@Maximo-Guk i've added back the created_on property, to all accounts
So this pr still cleans up a lot of unused properties, and keeps the created_on field, then in the future we can introduce pagination if needed
G4brym
force-pushed
the
improve-list-accounts-mcp-tool
branch
from
eafce4d to
1ace983
Compare
Maximo-Guk
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users with a lot of accounts are wasting a lot of llm tokens on unused information, this pr makes sure only required (id + name) fields are returned to the LLM