Add evals for the bindings server and a hyperdrive binding #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsparks
reviewed
Apr 30, 2025
| input: 'List all my Cloudflare accounts.', | ||
| expected: 'The accounts_list tool should be called to retrieve the list of accounts.', | ||
| }, | ||
| { |
There was a problem hiding this comment.
I would split these into separate describe eval scripts. Like
describeEval("List accounts", ...)
describeEval("Set account", ...)
Then you don't need to have the if statements below, because to me that feels like a bit of a code smell in tests.
cmsparks
requested changes
Apr 30, 2025
| const client = await initializeClient(/* Pass necessary mocks/config */) | ||
| const { promptOutput, toolCalls, fullResult } = await runTask(client, model, input) | ||
|
|
||
| if (input.includes('List all my Cloudflare KV Namespaces')) { |
There was a problem hiding this comment.
Same here, I'd split this into a separate describe eval.
Maximo-Guk
approved these changes
Apr 30, 2025
cmsparks
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tools for Hyperdrive and introduces evals to the workers-bindings MCP server