Workers Observability migrate responses to TSV's #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maximo-Guk
approved these changes
May 2, 2025
Maximo-Guk
reviewed
May 2, 2025
| @@ -32,6 +35,7 @@ export async function queryWorkersObservability( | |||
| method: 'POST', | |||
| headers: { | |||
| 'Content-Type': 'application/json', | |||
| 'workers-observability-origin': `workers-observability-mcp-${environment}`, | |||
There was a problem hiding this comment.
Maybe we can come up with a general header name, which every mcp server uses?
There was a problem hiding this comment.
This is specific to our backend, happy to add a general one too
There was a problem hiding this comment.
Awesome, maybe we can set our user agent to the server name / version ( the ones pulled from package.json )
Also doesn't have to be in this PR!
Maximo-Guk
approved these changes
May 2, 2025
…cloudflare/mcp-server-cloudflare into thomas/fix/response-token-usage
Maximo-Guk
reviewed
May 2, 2025
| @@ -23,6 +25,8 @@ export async function queryWorkersObservability( | |||
| accountId: string, | |||
| query: QueryRunRequest | |||
| ): Promise<z.infer<typeof zReturnedQueryRunResult> | null> { | |||
| // @ts-expect-error We don't have actual env in this package | |||
| const environment = env.ENVIRONMENT | |||
There was a problem hiding this comment.
We could probably also pass through this env in the params so we don't need to expect error here.
Kinda like what do here https://github.com/cloudflare/mcp-server-cloudflare/blob/main/packages/mcp-common/src/dev-mode.ts#L6
There was a problem hiding this comment.
Will fix in a follow up on monday :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.