Fix evals in CI #143
Merged
Fix evals in CI #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsparks
requested review from
deloreyj and
Maximo-Guk
and removed request for
deloreyj
Maximo-Guk
approved these changes
May 2, 2025
| @@ -54,6 +54,10 @@ export class ContainerMcpAgent extends McpAgent<Env, never, Props> { | |||
| Use this tool to initialize a container before running any python or node.js code that the user requests ro run.`, | |||
| // @ts-ignore | |||
| async () => { | |||
| console.log('initializing') | |||
There was a problem hiding this comment.
Remove log? Or maybe we should add some tags here?
There was a problem hiding this comment.
nah i'm gonna remove
| @@ -47,6 +49,7 @@ export async function runTask( | |||
| return acc | |||
| }, {} as ToolSet) | |||
|
|
|||
| console.log('streaming res') | |||
| description: v.description, | ||
| execute: async (args, opts) => { | ||
| execute: async (args: any, opts) => { |
There was a problem hiding this comment.
Just curious why set to this to :any ?
There was a problem hiding this comment.
This was just copypasted from the workers-bindings evals. IIRC this was to prevent eslint from complaining. We should honestly move this to be a common function though tbh (but I'll do that in a follow up pr)
cmsparks
force-pushed
the
csparks/fix-evals
branch
from
fa83d75 to
ae8bc13
Compare
cmsparks
force-pushed
the
csparks/fix-evals
branch
from
ae8bc13 to
9a750b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the containers evals. I fixed the evals and got dev mode in sync with the other folders in the repo