Move runTask to common evals package #144
Merged
+100
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsparks
requested review from
deloreyj and
Maximo-Guk
and removed request for
deloreyj
|
Been running into a bit of flakiness in the kv_namespaces tests, but not sure why. Pretty sure it's not related to this change specifically though. |
Maximo-Guk
approved these changes
May 2, 2025
cmsparks
force-pushed
the
csparks/move-runTask
branch
from
f8a39da to
c6f9822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runTask is the same in workers-bindings and sandbox-container. Lets move it to the common evals package.