Skip to content

Use full workers logs schema for workers logs tool responses #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions apps/workers-observability/src/tools/logs.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { z } from 'zod'

import { handleWorkerLogs, handleWorkerLogsKeys } from '@repo/mcp-common/src/api/logs'
import { handleWorkerLogs, handleWorkerLogsKeys } from '@repo/mcp-common/src/api/workers-logs'

import type { MyMCP } from '../index'

Expand All @@ -16,9 +16,9 @@ const limitParam = z
const minutesAgoParam = z
.number()
.min(1)
.max(1440)
.max(10080)
.default(30)
.describe('Minutes in the past to look for logs (1-1440, default 30)')
.describe('Minutes in the past to look for logs (1-10080, default 30)')
const rayIdParam = z.string().optional().describe('Filter logs by specific Cloudflare Ray ID')

/**
Expand Down Expand Up @@ -53,7 +53,7 @@ export function registerLogsTools(agent: MyMCP) {
}
try {
const { scriptName, shouldFilterErrors, limitParam, minutesAgoParam, rayId } = params
const { relevantLogs, from, to } = await handleWorkerLogs({
const { logs, from, to } = await handleWorkerLogs({
scriptName,
limit: limitParam,
minutesAgo: minutesAgoParam,
Expand All @@ -67,9 +67,8 @@ export function registerLogsTools(agent: MyMCP) {
{
type: 'text',
text: JSON.stringify({
logs: relevantLogs,
logs,
stats: {
total: relevantLogs.length,
timeRange: {
from,
to,
Expand Down Expand Up @@ -118,7 +117,7 @@ export function registerLogsTools(agent: MyMCP) {
}
try {
const { rayId, shouldFilterErrors, limitParam, minutesAgoParam } = params
const { relevantLogs, from, to } = await handleWorkerLogs({
const { logs, from, to } = await handleWorkerLogs({
limit: limitParam,
minutesAgo: minutesAgoParam,
accountId,
Expand All @@ -131,9 +130,8 @@ export function registerLogsTools(agent: MyMCP) {
{
type: 'text',
text: JSON.stringify({
logs: relevantLogs,
logs,
stats: {
total: relevantLogs.length,
timeRange: {
from,
to,
Expand Down Expand Up @@ -192,7 +190,7 @@ export function registerLogsTools(agent: MyMCP) {
keys: keys.map((key) => ({
key: key.key,
type: key.type,
lastSeen: key.lastSeen ? new Date(key.lastSeen).toISOString() : null,
lastSeenAt: key.lastSeenAt ? new Date(key.lastSeenAt).toISOString() : null,
})),
stats: {
total: keys.length,
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"check:turbo": "run-turbo check",
"test:ci": "run-vitest-ci",
"test": "vitest run",
"lint": "prettier . --write",
"fix:format": "prettier . --write",
"test:watch": "vitest"
},
"devDependencies": {
Expand Down
319 changes: 0 additions & 319 deletions packages/mcp-common/src/api/logs.ts

This file was deleted.

Loading