Python: Set up FFI before taking snapshot #4015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/finalize-bootstrap-earlier
branch
12 times, most recently
from
3cc391f to
84048f8
Compare
hoodmane
force-pushed
the
hoodmane/finalize-bootstrap-earlier
branch
2 times, most recently
from
7e24e7c to
db6fb30
Compare
dom96
approved these changes
Apr 29, 2025
hoodmane
force-pushed
the
hoodmane/finalize-bootstrap-earlier
branch
2 times, most recently
from
8a6f736 to
d37b057
Compare
In order to allow our memory snapshots to include packages that try to specifically support Pyodide and use the Pyodide ffi, or the transitive dependencies of such packages, we need to set up the ffi before we take the snapshot. Such packages include basically anything that makes requests, like urllib3, aiohttp, and httpx. Most of the work is actually handled by Pyodide upstream.
hoodmane
force-pushed
the
hoodmane/finalize-bootstrap-earlier
branch
from
d37b057 to
2d94bb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.