Python: Clean up state in snapshot.ts, NFC #4057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/cleanup-snapshot-metadata
branch
5 times, most recently
from
dbb05b0 to
0ae138c
Compare
hoodmane
force-pushed
the
hoodmane/cleanup-snapshot-metadata
branch
2 times, most recently
from
5e1ad0e to
f1d33cb
Compare
dom96
approved these changes
May 2, 2025
There was a problem hiding this comment.
Seems fine... though this is a lot of changes and the code is rather tough to follow. Do we have good test coverage for this?
As a general comment, I also wonder if it's possible to avoid globals completely for this code. Can we have a SnapshotState class that is instantiated at the start and holds all of this state? Not something that needs to be done as part of this PR, but perhaps something to consider for future refactorings.
|
We do have quite good test coverage for this. |
hoodmane
force-pushed
the
hoodmane/cleanup-snapshot-metadata
branch
from
f1d33cb to
3c2c42e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of global variables in
snapshot.tsfrom 8 to 2. The two new global variables areLOADED_SNAPSHOT_METAwhich contains information about a snapshot we loaded andCREATED_SNAPSHOT_METAwhich contains information about a snapshot we are in the process of creating.