Skip to content

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Sep 19, 2025

Fixes https://jira.cfdata.org/browse/DEVX-2200


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a v3 feature

@penalosa penalosa requested review from a team as code owners September 19, 2025 16:51
Copy link

changeset-bot bot commented Sep 19, 2025

🦋 Changeset detected

Latest commit: 1bdcfa3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Minor
@cloudflare/vite-plugin Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 19, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10710

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10710

miniflare

npm i https://pkg.pr.new/miniflare@10710

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10710

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10710

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10710

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10710

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10710

wrangler

npm i https://pkg.pr.new/wrangler@10710

commit: 1bdcfa3

@penalosa penalosa changed the title Add commented out remote bindings to newly created resources Add option to make newly created resources remote Sep 22, 2025
@penalosa penalosa force-pushed the penalosa/surface-remote-bindings branch from 5a7305c to 46db22e Compare September 22, 2025 20:52
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main penalosa/surface-remote-bindings might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10710
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@penalosa penalosa added the skip-v3-pr Skip validation of presence of a v3 backport PR label Sep 22, 2025
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 25, 2025
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that for any interactive prompt there should be a command line arg that can be used to avoid having to answer the prompt.

Currently, the only way to opt-out of most prompts is to run in non-interactive mode. But this is a heavy (and non-intuitive) hammer, since it doesn't allow fine grained control (you have to accept all the defaults).

I know that we don't do this for most prompts, but I think we should. And perhaps start here?

@petebacondarwin petebacondarwin force-pushed the penalosa/surface-remote-bindings branch from 1409733 to 39102e4 Compare September 28, 2025 06:51
@petebacondarwin
Copy link
Contributor

CI failures look legit

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@petebacondarwin
Copy link
Contributor

On the documentation front, do we need to, now, update the command options in cloudflare-docs?

@penalosa
Copy link
Contributor Author

@petebacondarwin potentially? But I'd quite like to see if the new docs generation can work here, which will need this to be released first. I'll make a docs issue

@penalosa penalosa merged commit 7f2386e into main Sep 30, 2025
36 of 38 checks passed
@penalosa penalosa deleted the penalosa/surface-remote-bindings branch September 30, 2025 16:10
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants