Skip to content

Conversation

danielrs
Copy link
Contributor

@danielrs danielrs commented Sep 25, 2025

Tracking internally: https://jira.cfdata.org/browse/WC-3931

Describe your change...

Enabling or disabling workers_dev is often an indication that the user is also trying to enable or disable preview_urls. Warn the user when these enter mixed state.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: just adding warns around existing features.
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a patch change.

@danielrs danielrs requested a review from a team as a code owner September 25, 2025 18:47
Copy link

changeset-bot bot commented Sep 25, 2025

🦋 Changeset detected

Latest commit: 9894b79

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 25, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10770

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10770

miniflare

npm i https://pkg.pr.new/miniflare@10770

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10770

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10770

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10770

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10770

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10770

wrangler

npm i https://pkg.pr.new/wrangler@10770

commit: 9894b79

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just the thing about using our standard env-var tools

@github-project-automation github-project-automation bot moved this from Untriaged to In Review in workers-sdk Sep 26, 2025
@danielrs danielrs force-pushed the drivas/wrangler-subdomain-mixed-state-warning branch 2 times, most recently from 07502f5 to c5ab709 Compare September 26, 2025 21:41
Enabling or disabling `workers_dev` is often an indication that
the user is also trying to enable or disable `preview_urls`. Warn the
user when these enter mixed state.
@danielrs danielrs force-pushed the drivas/wrangler-subdomain-mixed-state-warning branch from c053b99 to 9894b79 Compare September 29, 2025 15:18
@github-project-automation github-project-automation bot moved this from In Review to Approved in workers-sdk Sep 30, 2025
@petebacondarwin petebacondarwin merged commit 835d6f7 into cloudflare:main Oct 1, 2025
37 of 41 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Oct 1, 2025
@danielrs danielrs deleted the drivas/wrangler-subdomain-mixed-state-warning branch October 1, 2025 17:34
@lrapoport-cf lrapoport-cf mentioned this pull request Oct 2, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants