-
Notifications
You must be signed in to change notification settings - Fork 1k
wrangler: feat: validate Worker subdomain mixed state #10770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler: feat: validate Worker subdomain mixed state #10770
Conversation
🦋 Changeset detectedLatest commit: 9894b79 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - just the thing about using our standard env-var tools
07502f5
to
c5ab709
Compare
Enabling or disabling `workers_dev` is often an indication that the user is also trying to enable or disable `preview_urls`. Warn the user when these enter mixed state.
c053b99
to
9894b79
Compare
Tracking internally: https://jira.cfdata.org/browse/WC-3931
Describe your change...
Enabling or disabling
workers_dev
is often an indication that the user is also trying to enable or disablepreview_urls
. Warn the user when these enter mixed state.