Revert 10805 (Drop process polyfill when v2 is available) #10860
+70
−129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10855
Astro detects Node with:
With
unenv
process wouldtoString
as[object Object]
andisNode
isfalse
.The the v2 implementation from @guybedford it
toString
as[object process]
to match the Node implementation (this is correct) soisNode
becomestrue
However, when Node is detected, Astro construct a response from an
AsyncIterable
:But we know that workerd behavior does not conform to Node here, see cloudflare/workerd#2746. Fixing that issue would solve the Astro issue (i.e. we could drop the process polyfill).
However we will revert the PR dropping the polyfill for now.
Notes:
It looks like sentry is also using the same
isNode
check - we should inspect commonly used packages before dropping theprocess
polyfill again.There are a couples of additional changes on top of the revert:
process.toString
was updated