Skip to content

Fix _load_textdomain_just_in_time notice #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aihowes
Copy link

@aihowes aihowes commented May 20, 2025

Adds set_cloudinary_filters to the init hook.

Fixes #1038

Approach

  • The i18n function __() was being called in the constructor of the class which is considered to early
  • I have moved the relevant code to a separate function and added the function as an action to take place on init.

QA notes

  • Detail the steps needed to verify the PR.

aihowes added 2 commits May 20, 2025 16:58
Adds set_cloudinary_filters to the init hook.
Removes duplicated constructor docblock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_load_textdomain_just_in_time called too early – triggers notice in WP 6.8
1 participant