chore: Add additional metadata to reporting #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
May 6, 2025
| analyticsMetadata?: AnalyticsMetadata | ||
| ) { | ||
| const elementRef = useRef<T>(null); | ||
|
|
||
| useEffect(() => { | ||
| if (elementRef.current) { | ||
| const pkgMetadata = typeof packageMetadata === 'string' ? { version: packageMetadata } : packageMetadata; |
There was a problem hiding this comment.
Backward compatibility. I am planning to remove string type after migrating all consumers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 30 30
Lines 751 752 +1
Branches 199 195 -4
=======================================
+ Hits 746 747 +1
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michaeldowseza
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Allow easier debugging which theme is currently used in an app, by inspecting
element.__awsuiMetadata__.themepropertyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.