chore: Migrate "A" components to logical properties #1735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 653 653
Lines 17657 17657
Branches 5810 5810
=======================================
Hits 16657 16657
Misses 932 932
Partials 68 68 ☔ View full report in Codecov by Sentry. |
DaemonCahill
requested review from
michaeldowseza,
just-boris and
a team
and removed request for
a team
timogasda
reviewed
Nov 16, 2023
timogasda
reviewed
Nov 16, 2023
just-boris
reviewed
Nov 16, 2023
There was a problem hiding this comment.
All good from my end, but we need to address this thread: https://github.com/cloudscape-design/components/pull/1735/files?w=1#r1395369006
just-boris
reviewed
Nov 16, 2023
DaemonCahill
force-pushed
the
scottob-logical-properties-a-components
branch
from
f3cde1a to
93c013f
Compare
timogasda
previously approved these changes
Nov 17, 2023
just-boris
previously approved these changes
Nov 17, 2023
DaemonCahill
force-pushed
the
scottob-logical-properties-a-components
branch
from
098fb9c to
1c47e4f
Compare
DaemonCahill
dismissed stale reviews from timogasda and just-boris
via
24d1f45
connorlanigan
previously approved these changes
Dec 6, 2023
DaemonCahill
force-pushed
the
scottob-logical-properties-a-components
branch
from
b78f169 to
9331218
Compare
connorlanigan
previously approved these changes
Dec 6, 2023
connorlanigan
previously approved these changes
Dec 6, 2023
DaemonCahill
force-pushed
the
scottob-logical-properties-a-components
branch
from
b0bc3fa to
af7833b
Compare
katiegeorge
approved these changes
Dec 6, 2023
jperals
pushed a commit
that referenced
this pull request
Dec 7, 2023
just-boris
added a commit
that referenced
this pull request
Dec 13, 2023
This reverts commit e59a650.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a subset of the changes drafted in #1713 that affect only the subset of components that being with the letter "A".