Skip to content

Conversation

@jayantxie
Copy link
Member

@jayantxie jayantxie commented Sep 25, 2025

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix: 在 ttstream.RecvMsg 中使用与 stream 一致的 context,并修复 binary generic 的 nil message 异常

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: In the ttstream.RecvMsg call, if the incoming context is used as an imported parameter for pipeline.Read, it may lead to a failure of cancel pass-through; if used as an imported parameter for DecodePayload, it may lead to a failure of rpcinfo retrieval.
zh(optional): 在 ttstream.RecvMsg 调用中,如果使用传入的 context 作为 pipeline.Read 的入参,可能导致 cancel 透传失败,作为DecodePayload 入参,则可能导致 rpcinfo 获取失败

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners September 25, 2025 07:24
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.39%. Comparing base (cabe684) to head (8e936fb).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/generic/thrift/raw.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
+ Coverage   61.28%   61.39%   +0.10%     
==========================================
  Files         388      388              
  Lines       35024    35035      +11     
==========================================
+ Hits        21464    21508      +44     
+ Misses      12264    12236      -28     
+ Partials     1296     1291       -5     
Flag Coverage Δ
integration 50.28% <27.27%> (-0.05%) ⬇️
unit 51.60% <72.72%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jayantxie jayantxie force-pushed the fix/ttstream-context-consistency branch from dc758e4 to 0fd8994 Compare September 25, 2025 07:43
@jayantxie jayantxie changed the title fix: use consistent context in RecvMsg to ensure rpcinfo consistency fix: use consistent context in ttstream.RecvMsg and fix nil message error of binary generic Sep 25, 2025
@jayantxie jayantxie force-pushed the fix/ttstream-context-consistency branch from 0fd8994 to ac1ffd9 Compare September 25, 2025 07:47
DMwangnima
DMwangnima previously approved these changes Sep 25, 2025
@jayantxie jayantxie force-pushed the fix/ttstream-context-consistency branch from ac1ffd9 to 4eb8da4 Compare September 25, 2025 08:02
@jayantxie jayantxie changed the title fix: use consistent context in ttstream.RecvMsg and fix nil message error of binary generic fix: use consistent context of stream in ttstream.RecvMsg and fix nil message error of binary generic Sep 25, 2025
DMwangnima
DMwangnima previously approved these changes Sep 25, 2025
@YangruiEmma YangruiEmma changed the title fix: use consistent context of stream in ttstream.RecvMsg and fix nil message error of binary generic fix(ttstream): use consistent context of stream in ttstream.RecvMsg and fix nil message error of binary generic Sep 25, 2025
@jayantxie jayantxie merged commit 7018a57 into cloudwego:main Sep 25, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants