[BC breaks] Refactoring, added weather history, removed autoloader. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmfcmf
added a commit
that referenced
this pull request
Jan 23, 2014
[BC breaks] Refactoring, added weather history, removed autoloader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmfcmftoCmfcmf.new OpenWeatherMap()constructor changed. The first parameter now is an instance of a class implementingCmfcmf/OpenWeatherMap/FetcherInterface, which is responsible for fetching data from urls. Two fetchers are implemented, the old one usingfile_get_contents($url)and a new one using cURL. If you do not specify a fetcher, cURL will be used if it's available.copyrightstring was removed from all classes and is now only available viaOpenWeatherMap::COPYRIGHT.Due to the bc breaks, this will be (pre-)released as v2.0.0(-rc1) (following SemVer). The "final" 2.0.0 release will follow after some days of testing.