Memory memo tests #103
Closed
Memory memo tests #103
+115
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for testing this! @jopereira I have integrated the tests into #101, which is a branch I made where I rewrote the memo and optimizer. Could you please try your fuzzing based tests again? I plan to merge that PR once I wrap up merging the logical task graph (which should take me one extra day + testing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The memo is being tested only through optimizer tests.
Summary of changes
Add simple tests for key memo functionality, including insert, lookup, merge, and recursive merge of groups.
Limitation: These tests are currently using only logical expressions.