Break up Memo trait #97
Closed
+2,653
−1,211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem If we want users of the DSL to add their own UDFs, it makes more sense to have them recompile just the CLI with their functions rather than the entirety of `optd`. ## Summary of changes Extracts the `cli` module into its own crate. Ideally we figure out how to let users of the CLI add their own UDFs in an ergonomic way without having to fork our repository. This should be easy (could either use a proc macro or expose more of the compilation functions as building blocks in a library), and can be left to a later point in time.
Supports generic bounds in the type system. Partially tackles #81 . ``` fn <K: EqHash, V> (pairs: [(K, V)]) to_map(): {K: V} = match pairs | [head .. tail] -> {head#_0: head#_1} ++ tail.to_map() \ [] -> {} ``` Also removed the `None` type, as it was really just an `Option<Nothing>`. This creates some issues when comparing an option with `None`. I need to see what can be done to fix that small bug.
## Overview DSL functions can now be executed through the CLI with the `[run]` annotation. Try it out! `cargo run --bin optd-cli -- run-functions [path]/logical_rules.opt` ## Known Issues - Stack overflows *very* quickly due to the lack of TCO in the engine. Needs to be optimized. - Existing type inference issues.
As title, also refactored the annotation checking process.
|
Work integrated into #101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The memo trait was way too large.
Summary of changes
This PR breaks up the Memo table into 4 subtraits. See
src/memo/traits.rsfor more info.