Skip to content

Fix: Correcting factor names to use dash instead of underscore. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2021
Merged

Fix: Correcting factor names to use dash instead of underscore. #66

merged 1 commit into from
May 5, 2021

Conversation

JackAtOmenApps
Copy link
Collaborator

Corrects issue in #65 due to factor names containing underscores (which are then replaced with spaces and result in key errors)

@JackAtOmenApps JackAtOmenApps self-assigned this May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #66 (3d6693f) into master (ffb269c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          456       456           
=========================================
  Hits           456       456           
Impacted Files Coverage Δ
measurement/measures/mechanics.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb269c...3d6693f. Read the comment docs.

@JackAtOmenApps JackAtOmenApps merged commit 2fb3b95 into coddingtonbear:master May 5, 2021
@JackAtOmenApps JackAtOmenApps deleted the underscore_name_fix branch May 5, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant