Design and Implement the todos function #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crongro
approved these changes
Apr 15, 2019
Contributor
crongro
left a comment
crongro
left a comment
There was a problem hiding this comment.
다음 단계 할때 주의할 점 남겨드려요
- 하나의 함수 말고, 함수를 여러개 만들기.
- 리뷰남긴 것 수정하기.
4-1에서는 승인/머지 합니다
| } , [] );*/ | ||
|
|
||
| (type === 'all') | ||
| ? console.log(`현재 상태 => todo : ${status['todo']}, doing : ${status['doing']}, done : ${status['done']}`) |
Contributor
There was a problem hiding this comment.
삼항연산자는 좀 간단한 부분에서 유용해보여요.
조건문을 사용하면 좋겠어요.
| const status = { 'todo': 0, 'doing': 0, 'done': 0 }; | ||
|
|
||
| // for ..of 문 | ||
| const list = []; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hyodol & YM - Pair Programming
Design and Implement the todos function