-
-
Notifications
You must be signed in to change notification settings - Fork 739
fix : naming convention session / main erasing with long test.title/tags #4992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
julien-ft-64
wants to merge
1
commit into
codeceptjs:3.x
Choose a base branch
from
julien-ft-64:fix/3.x-sessions-playwright-traces
base: 3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2377,15 +2377,16 @@ class Playwright extends Helper { | |||||
| if (this.options.recordVideo && this.page && this.page.video()) { | ||||||
| test.artifacts.video = saveVideoForPage(this.page, `${test.title}.failed`) | ||||||
| for (const sessionName in this.sessionPages) { | ||||||
| test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${test.title}_${sessionName}.failed`) | ||||||
| if (sessionName === '') continue | ||||||
| test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${sessionName}_${test.title}.failed`) | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| if (this.options.trace) { | ||||||
| test.artifacts.trace = await saveTraceForContext(this.browserContext, `${test.title}.failed`) | ||||||
| for (const sessionName in this.sessionPages) { | ||||||
| if (!this.sessionPages[sessionName].context) continue | ||||||
| test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context, `${test.title}_${sessionName}.failed`) | ||||||
| if (!this.sessionPages[sessionName].context || sessionName === '') continue | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] Similarly, use a named constant for the main session check in the trace saving logic to improve clarity and avoid hard-coding empty string comparisons.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context(), `${sessionName}_${test.title}.failed`) | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -2399,7 +2400,8 @@ class Playwright extends Helper { | |||||
| if (this.options.keepVideoForPassedTests) { | ||||||
| test.artifacts.video = saveVideoForPage(this.page, `${test.title}.passed`) | ||||||
| for (const sessionName of Object.keys(this.sessionPages)) { | ||||||
| test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${test.title}_${sessionName}.passed`) | ||||||
| if (sessionName === '') continue | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] Consider using a consistent iteration approach (for example, either for...in or Object.keys) across the different loops for handling sessions to improve readability. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${sessionName}_${test.title}.passed`) | ||||||
| } | ||||||
| } else { | ||||||
| this.page | ||||||
|
|
@@ -2414,8 +2416,8 @@ class Playwright extends Helper { | |||||
| if (this.options.trace) { | ||||||
| test.artifacts.trace = await saveTraceForContext(this.browserContext, `${test.title}.passed`) | ||||||
| for (const sessionName in this.sessionPages) { | ||||||
| if (!this.sessionPages[sessionName].context) continue | ||||||
| test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context, `${test.title}_${sessionName}.passed`) | ||||||
| if (!this.sessionPages[sessionName].context || sessionName === '') continue | ||||||
| test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context(), `${sessionName}_${test.title}.passed`) | ||||||
| } | ||||||
| } | ||||||
| } else { | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider defining a constant (e.g. MAIN_SESSION) for the main session check instead of using an empty string literal, to enhance code clarity and maintainability.
Copilot uses AI. Check for mistakes.