Always specify coffeelint.json as default config #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this work if there is no |
|
@gordondiggs ah no it does not. Good catch, thanks. |
ABaldwinHunter
force-pushed
the
abh-config
branch
5 times, most recently
from
0867360 to
b21ee77
Compare
|
@gordondiggs updated! |
| def config_path | ||
| if @config | ||
| @config | ||
| elsif File.exist? DEFAULT_CONFIG_PATH |
There was a problem hiding this comment.
💄 parentheses around the arguments here
ABaldwinHunter
force-pushed
the
abh-config
branch
from
b21ee77 to
cac2aee
Compare
| @files = files | ||
| @config = config |
There was a problem hiding this comment.
reordered for style
|
@gordondiggs ready for another look! |
|
|
||
| private | ||
|
|
||
| attr_reader :config |
There was a problem hiding this comment.
Sorry if I wasn't clear before - I think this is the opportunity for all 3 ivars to become attr_readers and accessed that way. It seems worse to only have one
added 2 commits
August 10, 2016 11:18
This sidesteps an issue with resolving the config and location of node_modules for coffeelint projects using plugins: clutchski/coffeelint#571
Needed after dockerfile change: 2465bed
ABaldwinHunter
force-pushed
the
abh-config
branch
from
cac2aee to
260c7f4
Compare
|
@gordondiggs good call on attr_readers. Updated |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sidesteps an issue with resolving the config and location of node_modules
for coffeelint projects using plugins:
clutchski/coffeelint#571
@codeclimate/review