⚡️ Speed up function _get_url by 28%
#30
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 28% (0.28x) speedup for
_get_urlinsentry_sdk/integrations/_asgi_common.py⏱️ Runtime :
6.71 milliseconds→5.23 milliseconds(best of43runs)📝 Explanation and details
The optimization achieves a 28% speedup through two key performance improvements:
1. Dictionary lookup optimization for default ports:
{"http": 80, "https": 443, "ws": 80, "wss": 443}on every call and performs.get(scheme)80 if scheme in ("http", "ws") else 443 if scheme in ("https", "wss") else None2. String formatting optimization:
%formatting:"%s://%s%s" % (scheme, host, path)f"{scheme}://{host}{path}"3. Minor cleanup:
Noneargument fromasgi_scope.get("server", None)sinceNoneis the defaultPerformance characteristics from test results:
The optimization is most effective for typical ASGI applications that frequently construct URLs with server information and non-standard ports.
✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-_get_url-mg9g4mz4and push.