Update portfolio.spec.js #523
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code has been improved by switching to the modern JSDOM API instead of the deprecated jsdom.jsdom method, and by reading the HTML file as UTF-8 text for proper character handling. The variable names now leverage destructuring for clarity. All textContent checks are enhanced with .trim() to prevent false positives from whitespace-only content. Additionally, the test for the HTML skill in the skills section now asserts for at least one occurrence, accommodating flexibility in the user’s list. Overall, the changes make the test code more robust, modern, and reliable, ensuring clearer error messages and better alignment with current JavaScript and testing best practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been improved by switching to the modern JSDOM API instead of the deprecated jsdom.jsdom method, and by reading the HTML file as UTF-8 text for proper character handling. The variable names now leverage destructuring for clarity. All textContent checks are enhanced with .trim() to prevent false positives from whitespace-only content. Additionally, the test for the HTML skill in the skills section now asserts for at least one occurrence, accommodating flexibility in the user’s list. Overall, the changes make the test code more robust, modern, and reliable, ensuring clearer error messages and better alignment with current JavaScript and testing best practices.