[Feature] Add tests of state manager #2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyamore88
requested review from
neSpecc,
gohabereg and
khaydarov
as code owners
gohabereg
approved these changes
Apr 17, 2022
…js into feature/tests-of-state-manager � Conflicts: � src/components/store/createStore.ts � src/components/store/demo.ts
Base automatically changed from
feature/state-manager
to
feature/collaborative-editing
May 5, 2022 11:26
…/editor.js into feature/tests-of-state-manager � Conflicts: � src/components/store/createStore.ts � src/components/store/demo.ts � src/components/store/index.ts � types/store/reducer.ts � types/store/store.ts
gohabereg
approved these changes
May 6, 2022
neSpecc
reviewed
May 11, 2022
| * | ||
| * @param block - new block data | ||
| */ | ||
| export const createBlock = (block: OutputBlockData): CreateBlockAction => ({ |
There was a problem hiding this comment.
why anonymous function? Its better to create regular named function:
function createBlock(block: OutputBlockData): CreateBlockAction {
return {
// ...
}
}There was a problem hiding this comment.
and probably it would better to name it makeCreateBlockAction because that is what this function does.
TatianaFomina
approved these changes
May 12, 2022
neSpecc
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this request I've added tests for our state manager.