Skip to content

Try to fix console and .repl #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 17, 2023
Merged

Try to fix console and .repl #2743

merged 4 commits into from
Sep 17, 2023

Conversation

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Sep 17, 2023 •
edited
Loading

Tries to fix #2704 by ensuring the system streams are properly inherited when running .console or .repl with -i.

Tested via

> ./mill show dev.launcher

> cd example/basic/1-simple-scala

> /Users/lihaoyi/Github/mill/out/dev/launcher.dest/run  -i console

Notably this cannot be tested via dev.run, because we would need to apply the same SystemStreams.withStreams(SystemStreams.original) wrapper to dev.run, which would first require re-bootstrapping Mill on top of this PR

@lihaoyi lihaoyi merged commit 4e6de57 into com-lihaoyi:main Sep 17, 2023
@lefou lefou modified the milestones: 0.11.3, 0.11.4 Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.11.3

Development

Successfully merging this pull request may close these issues.

-i/--interactive not working

2 participants

@lihaoyi @lefou