Skip to content

Conversation

@lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Feb 14, 2025

  • Break up mill.client into mill.client and mill.constants, only depend on constants through most of the codebase and only use client in runner.
    • The name constants sucks but the dependency graph is better, we can change the name later if we can think of a better one
  • Interp#watch should live on MainModule rather than BaseModule, since ExternalModules should not need it
  • MillBuildBootstrap should work with RootModule rather than BaseModule, since you never need to bootstrap ExternalModules
  • Pull some stuff out of MainModule into separate files
  • mill.define.Watchable moved to mill.define.internal.Watchable
  • Made ModuleTask private and documented the hack
  • Got rid of the Applicative.Applyer trait and inlined def ctx() where necessary
  • Lots of ScalaDoc

@lihaoyi lihaoyi marked this pull request as ready for review February 14, 2025 02:24
@lihaoyi lihaoyi changed the title Simplify BaseModule handling More cleanup Feb 14, 2025
@lihaoyi lihaoyi force-pushed the cleanup-module branch 2 times, most recently from 75cd1c6 to fe0360a Compare February 14, 2025 03:49
@lihaoyi lihaoyi merged commit 9fbfc7b into com-lihaoyi:main Feb 14, 2025
30 of 31 checks passed
@lefou lefou added this to the 0.13.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants