Skip to content

Move launcher-specific cache files into out/mill-launcher/ folder to tidy up out/ folder root #5377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

Move launcher-specific cache files into out/mill-launcher/ folder to tidy up out/ folder root #5377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
975aa46
.
lihaoyi Jun 26, 2025
af07594
.
lihaoyi Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions runner/launcher/src/mill/launcher/MillProcessLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ static List<String> loadMillConfig(String key) throws Exception {
Path buildFile = Paths.get(rootBuildFileName);
if (Files.exists(buildFile)) {
String[] config = cachedComputedValue(
"yaml-config-" + key,
key,
mill.constants.Util.readBuildHeader(
buildFile, buildFile.getFileName().toString()),
() -> {
Expand Down Expand Up @@ -249,7 +249,7 @@ static String[] cachedComputedValue(String name, String key, Supplier<String[]>
static String[] cachedComputedValue0(
String name, String key, Supplier<String[]> block, Function<String[], Boolean> validate) {
try {
Path cacheFile = Paths.get(".").resolve(out).resolve("mill-" + name);
Path cacheFile = Paths.get(".").resolve(out).resolve("mill-launcher/" + name);
String[] value = null;
if (Files.exists(cacheFile)) {
String[] savedInfo = Files.readString(cacheFile).split("\n");
Expand Down