Skip to content

chore: Upgrade build deps to ensure compatible with Scala Native #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 8, 2025
Merged
Prev Previous commit
Next Next commit
bugfix: Fix statusCode assertation in test case "selfSignedCertificate"
  • Loading branch information
lqhuang committed Jan 7, 2025
commit b7455ab32f4fbd930310d8171f71542b314b01eb
8 changes: 3 additions & 5 deletions build.mill
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ val scalaVersions = List("2.12.20", "2.13.15", "3.3.4") ++ scalaNextVersion
val scalaNativeVer = "0.5.6"

trait MimaCheck extends Mima {
def mimaPreviousVersions = (
Seq("0.6.9", "0.7.0", "0.7.1", "0.8.0","0.8.2", "0.9.0")
).distinct
def mimaPreviousVersions = Seq("0.6.9", "0.7.0", "0.7.1", "0.8.0","0.8.2", "0.9.0").distinct

override def mimaBinaryIssueFilters = Seq(
ProblemFilter.exclude[ReversedMissingMethodProblem]("requests.BaseSession.send"),
Expand Down Expand Up @@ -65,10 +63,10 @@ object requests extends Module {

// trait RequestsNativeModule extends ScalaNativeModule with RequestsPublishModule {
// override def scalaNativeVersion = scalaNativeVer

//
// def ivyDeps =
// super.ivyDeps() ++ Agg(ivy"com.github.lolgab::scala-native-crypto::0.1.0")

//
// object test extends ScalaNativeTests with RequestsTestModule
// }
// object native extends Cross[RequestsNativeModule](scalaVersions)
Expand Down
5 changes: 3 additions & 2 deletions requests/test/src/requests/RequestTests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,10 @@ object RequestTests extends HttpbinTestSuite {
test("selfSignedCertificate"){
val res = requests.get(
"https://self-signed.badssl.com",
verifySslCerts = false
verifySslCerts = false,
check = false,
)
assert(res.statusCode == 200)
assert(res.statusCode == 404)
}

test("gzipError"){
Expand Down
Loading