Skip to content

SDist code deling with custom-setup incorrect #4006

Closed
@istathar

Description

@istathar

When uploading http-streams using stack upload . (ie the sdist step) I get the following warning:

Warning: In getPackageArgs: custom-setup in use, but no dependency map present
Could not find custom-setup dep: Cabal
Could not find custom-setup dep: base

which is weird because the .cabal file in question has what I was told to put there previously:

...
custom-setup
  setup-depends:     base >= 4.5,
                     Cabal >= 1.24

...

I asked in the Haskell channel at work and the epic @SamRoberts read through the stack code and in short order found the message is emitted from Execute.hs's function withSingleContext. Its fourth argument is a Maybe (Map something something).

This appears to be called from SDist.hs where the fourth argument is hard coded to Nothing. Hence warning.

Seems either the Nothing is wrong and we need to pass in the custom-setup (?) map or the warning code needs to know that it's not going to actually get a map and not warn.

AfC

feel free to change the issue title to something more helpful

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions