Skip to content

Introduces $locals et al ghc-options keys #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2017
Merged

Conversation

snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Aug 9, 2017

Closes #3329. This also fixes a regression I introduced in the previous
commit on ghc-options, which mistakenly assumed ghc-options were
supposed to be given as a list instead of a single Text value.

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@snoyberg snoyberg requested a review from mgsloan August 9, 2017 14:56
Closes #3329. This also fixes a regression I introduced in the previous
commit on ghc-options, which mistakenly assumed ghc-options were
supposed to be given as a list instead of a single Text value.
@snoyberg snoyberg force-pushed the 3329-locals-options branch from 258906b to 073dad9 Compare August 9, 2017 15:55
Copy link
Contributor

@mgsloan mgsloan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snoyberg snoyberg merged commit 2c8747c into master Aug 9, 2017
@snoyberg snoyberg deleted the 3329-locals-options branch August 9, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for $locals and $everything keys in ghc-options
2 participants