Exception occurs when subject is not provided

[Lee-W]

It happens due to this line.
https://github.com/Woile/commitizen/blob/master/commitizen/cz/conventional_commits/conventional_commits.py#L29

In cz-cli, they simple ignore it and generate an empty commiit.

I like your idea more, but it seems to me that we can handle the exception in a better way.

[woile]

Yeah, to me it doesn't make sense if no subject is provided. Wanna make a PR to catch the filter errors?

[Lee-W]

🙆‍♂

[Lee-W]

In the current implementation, the NoSubjectException is an exception only for ConventionalCommitsCz. Thus, it does not make sense to me to catch this exception in commands/commit.py.
Maybe we can add a error.py under cz/ which contains all the possible exception and a base exception like CommitzenException so that catching CommitzenException in commands/commit.py would make more sense.
What do you think about this idea?

[woile]

I like the idea, I would call the file exceptions.py though

[woile]

Thanks for the help @Lee-W I'm closing this issue now