Skip to content

Conversation

@woile
Copy link
Member

@woile woile commented Jul 25, 2020

Types of changes

  • Bug fix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe)

Description

Use return code in bump and commit

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually

Steps to Test This Pull Request

  1. Create a fake repo
  2. Add pre-commit hooks
  3. Start bumping/commiting

Expected behavior

Hooks should be displayed normally, instead of like an error.

Related Issue

Closes #197 #222

@woile woile requested a review from Lee-W July 25, 2020 13:27
@codecov
Copy link

codecov bot commented Jul 25, 2020

Codecov Report

Merging #229 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   95.64%   95.70%   +0.05%     
==========================================
  Files          34       34              
  Lines         942      955      +13     
==========================================
+ Hits          901      914      +13     
  Misses         41       41              
Flag Coverage Δ
#unittests 95.70% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/cmd.py 100.00% <100.00%> (ø)
commitizen/commands/bump.py 90.58% <100.00%> (-0.88%) ⬇️
commitizen/commands/changelog.py 97.29% <100.00%> (+0.07%) ⬆️
commitizen/commands/commit.py 98.27% <100.00%> (+1.78%) ⬆️
commitizen/config/__init__.py 97.67% <100.00%> (ø)
commitizen/git.py 95.45% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e37e3e6...107fa25. Read the comment docs.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@woile woile merged commit ec4900a into master Jul 25, 2020
@woile woile deleted the fix/return-code-catch branch July 25, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

commitzen modifies the output from pre-commit and makes it hard to see

2 participants