Skip to content

Conversation

@dtrodrigues
Copy link
Contributor

Description

Changes the build backend from poetry to poetry_core. poetry_core is lighter weight than poetry and all that's required for the build vs project management aspect of poetry.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

https://python-poetry.org/docs/pyproject/#poetry-and-pep-517

If your pyproject.toml file still references poetry directly as a build backend, you should update it to reference poetry-core instead.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with it. Seem to be the recommended way https://python-poetry.org/docs/pyproject/#poetry-and-pep-517

@woile what do you think?

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #460 (1216a9e) into master (48f9b7e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files          39       39           
  Lines        1424     1424           
=======================================
  Hits         1395     1395           
  Misses         29       29           
Flag Coverage Δ
unittests 97.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddd68d...1216a9e. Read the comment docs.

@Lee-W Lee-W requested a review from woile December 22, 2021 15:00
@woile woile merged commit b009142 into commitizen-tools:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants