Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 21, 2025

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Jul 21, 2025
@manusa manusa added this to the 0.1.0 milestone Jul 21, 2025 — with automated-tasks
@manusa
Copy link
Member

manusa commented Jul 22, 2025

I'm not merging this because I'm not sure we have a valid Test to verify nothing breaks in go-oidc.

Please @ardaguclu, I'd need to know how you're (exploratory) testing the OIDC flow so I can check for breakages.

@ardaguclu
Copy link
Member

For now we can assume that bumps will be backwards compatible. Besides, these flags are hidden.

It is very nice to add test cases to increase the coverage. But in my opinion, some functionalities will require e2e test instead of unit test, such as oidc.

@ardaguclu
Copy link
Member

I think, we can merge this

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-jose/go-jose/v4-4.1.1 branch 3 times, most recently from 6afe550 to 5e7dda6 Compare July 29, 2025 04:43
@manusa
Copy link
Member

manusa commented Jul 29, 2025

@dependabot recreate

---
updated-dependencies:
- dependency-name: github.com/go-jose/go-jose/v4
  dependency-version: 4.1.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-jose/go-jose/v4-4.1.1 branch from 5e7dda6 to e1079f3 Compare July 29, 2025 11:36
@manusa manusa merged commit 94f7055 into main Jul 29, 2025
11 of 13 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/go-jose/go-jose/v4-4.1.1 branch July 29, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants