Skip to content

Beta fixes #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2017
Merged

Beta fixes #151

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b30035
Fix deprecations that appeared in Xcode 9.1
Nov 2, 2017
7abb512
Remove incorrect assertion that all links are resolved
Nov 2, 2017
71701ea
Refactor decoding of heterogenous EntryDecodables collections
Nov 2, 2017
24cdbe0
Update changelog and bump version to 1.0.0-beta2
Nov 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove incorrect assertion that all links are resolved
  • Loading branch information
JP Wright committed Nov 2, 2017
commit 7abb51249bf88f279a5cac1f4fd9f31317ddf063
1 change: 0 additions & 1 deletion Sources/Contentful/Entry.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public class Entry: LocalizableResource {

// The conversion from dictionary representation should only ever happen once
let alreadyResolvedLinks = mixedLinks.filter { $0.isResolved == true }
assert(alreadyResolvedLinks.count == 0)

let unresolvedLinks = mixedLinks.filter { $0.isResolved == false }
let newlyResolvedLinks = unresolvedLinks.map { $0.resolve(against: includedEntries, and: includedAssets) }
Expand Down