Skip to content

Fix decoding error for embedded entry-hyperlinks #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sjaindl
Copy link

@sjaindl sjaindl commented Dec 14, 2020

We experienced a decoding error when we had a hyperlink linking to another entry that contains another hyperlink in its content block.

Turned out that it was an issue due to missing encoding for ResourceLinkInline - the data property was not encoded, which led to a decoding error.

@tomkowz tomkowz requested review from tomkowz and makinwab December 16, 2020 11:03
Copy link
Contributor

@tomkowz tomkowz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@makinwab makinwab merged commit 82fdfc1 into contentful:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants