Skip to content

chore: migrate eslint-plugin-import to eslint-plugin-import-x #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented Jun 23, 2025

Description

close #4411

cc @escapedcat

Motivation and Context

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codesandbox-ci bot commented Jun 23, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin JounQin force-pushed the chore/eslint-plugin-import-x branch from 0b3a896 to 1b3f2a8 Compare June 23, 2025 02:41
@JounQin JounQin force-pushed the chore/eslint-plugin-import-x branch from 1b3f2a8 to add918a Compare June 23, 2025 02:45
@JounQin JounQin requested review from Copilot and escapedcat June 23, 2025 02:52
@JounQin JounQin added the dependencies Pull requests that update a dependency file label Jun 23, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates ESLint’s import plugin from eslint-plugin-import to eslint-plugin-import-x and updates related configurations, and also adjusts test-environment dependencies.

  • Remove eslint-plugin-import and compatibility shim, add eslint-plugin-import-x and its TypeScript resolver
  • Update eslint.config.mjs to use the new plugin prefixes and flat config
  • In the test-environment package, remove Jest environment and add Vitest

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Drop eslint-plugin-import & @eslint/compat, add import-x deps
eslint.config.mjs Swap import-plugin rules and imports to import-x equivalents
@packages/test-environment/package.json Remove Jest env, add Vitest as a dependency
Comments suppressed due to low confidence (2)

@packages/test-environment/package.json:34

  • [nitpick] Vitest was added as a test dependency, but there are no updates to test scripts or CI configurations. Consider adding or updating test entries to ensure Vitest runs correctly.
    "vitest": "^3.0.0"

eslint.config.mjs:25

  • The @eslint/compat dependency was removed from package.json but compat.extends(...) remains in the config. Re-add @eslint/compat or remove the compat.extends call to avoid configuration errors.
	...compat.extends('eslint:recommended', 'prettier'),

@escapedcat escapedcat merged commit bb872dd into conventional-changelog:master Jun 23, 2025
11 checks passed
@JounQin JounQin deleted the chore/eslint-plugin-import-x branch June 23, 2025 10:09
@JounQin JounQin self-assigned this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

[Deps]: migrate eslint-plugin-import to eslint-plugin-import-x
2 participants